Matthias Clasen [Tue, 10 Nov 2015 17:26:05 +0000 (12:26 -0500)]
Adwaita: update tooltip styling
Adapt to the changes in the previous commit. Note that tooltip
appearance is currently affected by tooltips having lost their
csd nature, due to a regression.
Emmanuele Bassi [Tue, 10 Nov 2015 14:12:35 +0000 (14:12 +0000)]
Move GtkAccelMap autocleanup to the class header
Emmanuele Bassi [Tue, 10 Nov 2015 14:11:04 +0000 (14:11 +0000)]
Recursively move autocleanups to their header files
Start from GtkAccelLabel and walk the tree downwards.
Emmanuele Bassi [Tue, 10 Nov 2015 14:08:07 +0000 (14:08 +0000)]
Move GtkAboutDialog autocleanup to the class header
Emmanuele Bassi [Tue, 10 Nov 2015 14:07:41 +0000 (14:07 +0000)]
Move GtkDialog autocleanup to the class header
Emmanuele Bassi [Tue, 10 Nov 2015 13:59:36 +0000 (13:59 +0000)]
Start recursively moving autocleanups macros to their headers
* Cover letter
Having a single header file for all autocleanups definitions was a
reasonable stop-gap measure, but now GTK+ is starting to use G_DECLARE_*
macros. This means that every class using a G_DECLARE_* macro will need
to include "gtk.h" to avoid compiler warnings, which is not acceptable.
By moving the G_DEFINE_AUTO* use to the header that defines the type we
allow using the G_DECLARE_* macros without sacrificing the ability to
include only the needed files when deriving from a class.
* Commit
This commit changes all includes relative to GtkWindow to define their
own autocleanup macros.
Emmanuele Bassi [Tue, 10 Nov 2015 13:49:11 +0000 (13:49 +0000)]
Only include the necessary headers in GtkPlacesViewRow
When compiling inside GTK we also use the GTK_COMPILATION guard, as the
GtkPlacesView and GtkPlacesViewRow widgets are shared with Nautilus.
Emmanuele Bassi [Tue, 10 Nov 2015 13:48:31 +0000 (13:48 +0000)]
Move GtkListBox g_autoptr macros to the class header
This allows GtkPlacesViewRow to use G_DECLARE_FINAL_TYPE without having
to include gtk.h.
Emmanuele Bassi [Tue, 10 Nov 2015 13:36:29 +0000 (13:36 +0000)]
Remove an unused variable declaration
And the compiler warning that comes with it.
Emmanuele Bassi [Tue, 10 Nov 2015 13:34:33 +0000 (13:34 +0000)]
Move GtkWindow g_autoptr macros in the class header
Otherwise we won't be able to use G_DECLARE_* macros internally to GTK
without generating warnings, or without including gtk.h itself.
Emmanuele Bassi [Tue, 10 Nov 2015 13:24:05 +0000 (13:24 +0000)]
docs: Ignore GtkTooltipWindow's private header file
Matthias Clasen [Tue, 10 Nov 2015 11:34:15 +0000 (06:34 -0500)]
Fix an oversight
We must set the construct-only "type" to GTK_WINDOW_POPUP, otherwise
this ends upo being a regular toplevel.
Emmanuele Bassi [Sun, 8 Nov 2015 17:10:00 +0000 (17:10 +0000)]
Use CSS node name for GtkTooltipWindow
Instead of a style class.
Emmanuele Bassi [Sun, 8 Nov 2015 15:46:23 +0000 (15:46 +0000)]
Add GtkTooltipWindow private sub-class
GtkTooltip does a lot of set up on the GtkWindow it uses internally. We
should move that code to a separate class to keep it contained.
Matthias Clasen [Tue, 10 Nov 2015 12:45:56 +0000 (07:45 -0500)]
print dialog: Avoid gtk_style_context_save
There was one more call to gtk_style_context_save here that I
overlooked. We can get rid of it by just setting the element name
on the drawing area.
Matthias Clasen [Tue, 10 Nov 2015 12:39:40 +0000 (07:39 -0500)]
flowbox: Add a diagram to CSS documentation
Matthias Clasen [Tue, 10 Nov 2015 12:37:25 +0000 (07:37 -0500)]
iconview: Add a diagram to CSS documentation
Matthias Clasen [Tue, 10 Nov 2015 12:36:41 +0000 (07:36 -0500)]
treeview: Add a diagram to CSS documentation
Matthias Clasen [Tue, 10 Nov 2015 12:31:32 +0000 (07:31 -0500)]
HighContrast: Update treeview rubberband styling
Adapt to the changes in the previous commit.
Matthias Clasen [Tue, 10 Nov 2015 12:30:29 +0000 (07:30 -0500)]
Adwaita: Update treeview rubberband styling
Adapt to the changes in the previous commit.
Matthias Clasen [Tue, 10 Nov 2015 12:29:54 +0000 (07:29 -0500)]
treeview: Use a CSS node for rubberband drawing
Use a CSS node with name rubberband to draw the rubberband
selection.
Alexander Larsson [Mon, 9 Nov 2015 21:18:05 +0000 (22:18 +0100)]
TextView: Use saner coordinate space in draw_layer.
When I added the draw_layer vfunc it accidentally got passed a cairo_t
that was configured with to draw in the viewport coordinate space (rather
than the buffer coordinate space). This makes things unnecessary complex,
because you have to convert between the two.
The pixel cache is shared between the text and the layers, so there is
no way to use draw_layer to get a stationary overlay effect. Thus it makes
much more sense for the draw_layer vfunc to draw in the buffer space.
Just changing this would break ABI for existing code, so this is fixed
by adding new layer types and deprecating the old ones.
Also, we use the new layer types to fix gtk3-widget-factory.
https://bugzilla.gnome.org/show_bug.cgi?id=757856
Matthias Clasen [Tue, 10 Nov 2015 05:55:57 +0000 (00:55 -0500)]
Forgotten file
This change belongs to the iconview rubberband changes.
Matthias Clasen [Tue, 10 Nov 2015 05:55:29 +0000 (00:55 -0500)]
HighContrast: Update flowbox rubberband styling
Adapt to the changes in the previous commit.
Matthias Clasen [Tue, 10 Nov 2015 05:52:09 +0000 (00:52 -0500)]
Adwaita: Update flowbox rubberband styling
Adapt to the changes in the previous commit.
Matthias Clasen [Tue, 10 Nov 2015 05:50:42 +0000 (00:50 -0500)]
flowbox: Use a CSS node for rubberband drawing
Use a CSS node with name rubberband to draw the rubberband
selection.
Matthias Clasen [Tue, 10 Nov 2015 05:30:39 +0000 (00:30 -0500)]
HighContrast: Update rubberband styling
Adapt to the changes in the previous commit.
Matthias Clasen [Tue, 10 Nov 2015 05:28:46 +0000 (00:28 -0500)]
Adwaita: Update rubberband styling
Adapt to the changes in the previous commit.
Matthias Clasen [Tue, 10 Nov 2015 05:25:19 +0000 (00:25 -0500)]
iconview: Use a CSS node for rubberband drawing
Use a CSS node with name rubberband to draw the rubberband
selection.
Matthias Clasen [Tue, 10 Nov 2015 04:49:29 +0000 (23:49 -0500)]
HighContrast: Update text handle styling
Adapt to the changes in the previous release.
Matthias Clasen [Tue, 10 Nov 2015 04:47:08 +0000 (23:47 -0500)]
Adwaita: Update text handle styling
Adapt to the changes in the previous commit.
Matthias Clasen [Tue, 10 Nov 2015 04:45:29 +0000 (23:45 -0500)]
Document text handle styling
Since GtkTextHandle is private, document text handle style
classes in the GtkEntry and GtkTextView documentation.
Matthias Clasen [Tue, 10 Nov 2015 04:33:54 +0000 (23:33 -0500)]
text handle: Port to CSS nodes
Use cursor-handle as the element name for the CSS node that
is used to render text the selection handles.
Matthias Clasen [Mon, 9 Nov 2015 14:27:40 +0000 (09:27 -0500)]
Avoid excessive property notification for GtkStack::interpolate-size
make check checks this for writable properties, and fails now that
we've made this property writable.
Matthias Clasen [Mon, 9 Nov 2015 18:33:58 +0000 (13:33 -0500)]
notebook: Update CSS docs
The .header style class is no longer used.
Timm Bäder [Sat, 31 Oct 2015 17:05:03 +0000 (18:05 +0100)]
colorswatch: Don't pass _GENERIC_FALLBACK to API that doesn't support it
Alexander Larsson [Mon, 9 Nov 2015 14:14:57 +0000 (15:14 +0100)]
gdk: Fix invalidation w/ pixel cache when changing child window geometry.
When moving/scrolling a child window we can't use the current clip
region to limit what is invalidated, because there may be a pixel
cache that listens for changes outside the clip region. Instead
invalidate the entire area and rely on the invalidation code to limit
the repaint to the actually visible area.
Benjamin Otte [Mon, 9 Nov 2015 13:17:09 +0000 (14:17 +0100)]
textdisplay: save/restore when using different state flags
Also, never use gtk_widget_get_state_flags() when we want
gtk_style_context_get_state()
Olivier Fourdan [Mon, 9 Nov 2015 11:05:37 +0000 (12:05 +0100)]
gtkwindow: Fix resize without "_GTK_FRAME_EXTENTS"
git commit
a5b1cdd0 introduced a regression where CSD windows are not
resizable with metacity.
Reason being that metacity does not support "_GTK_FRAME_EXTENTS" and
therefore gtk_window_supports_client_shadow() would always return FALSE.
This explains why it works with window managers which support
"_GTK_FRAME_EXTENTS" such as mutter/gnome-shell or xfwm4.
Partially revert commit
a5b1cdd0 to reinstate the logic in
get_shadow_width().
Bugzilla: https://bugzilla.gnome.org/show_bug.cgi?id=757805
Matthias Clasen [Mon, 9 Nov 2015 12:40:44 +0000 (07:40 -0500)]
container: Slightly reword some docs
Clarify gtk_container_remove documentation regarding reference
holding. Suggested in
https://bugzilla.gnome.org/show_bug.cgi?id=757607
Matthias Clasen [Mon, 9 Nov 2015 11:42:59 +0000 (06:42 -0500)]
tool item group: Use a CSS node for the arrow
This completes the transition for GtkToolItemGroup.
Matthias Clasen [Mon, 9 Nov 2015 01:59:55 +0000 (20:59 -0500)]
HighContrast: Update notebook styling
Some fixes for arrows and for headers.
Matthias Clasen [Sun, 8 Nov 2015 23:11:25 +0000 (18:11 -0500)]
Adwaita: Update notebook styling
Adapt to the changes in the previous commit.
Matthias Clasen [Sun, 8 Nov 2015 20:01:09 +0000 (15:01 -0500)]
notebook: Use CSS nodes for arrows
This converts the drawing of scroll arrows to use separate CSS
nodes.
Matthias Clasen [Mon, 9 Nov 2015 01:27:22 +0000 (20:27 -0500)]
Don't use a transient node in gtk_render_arrow()
It is not necessary for the users of this API, and causes things
to not work as intended. Without this transient node, styling
"notebook header tabs arrow" has the desired effect on notebook
arrows.
Matthias Clasen [Sat, 7 Nov 2015 18:17:17 +0000 (13:17 -0500)]
widget-factory: Add another notebook example
This example shows a scrollable notebook with action widgets.
Matthias Clasen [Sat, 7 Nov 2015 16:31:24 +0000 (11:31 -0500)]
HighContrast: update notebook styling
Adapt to the changes in the previous commit.
Matthias Clasen [Sat, 31 Oct 2015 14:25:50 +0000 (10:25 -0400)]
Adwaita: Adapt notebook styling a bit
This needs a lot more work.
Matthias Clasen [Sat, 31 Oct 2015 14:23:40 +0000 (10:23 -0400)]
notebook: redo notebook styling
Add a header node, and put positional classes on it.
Benjamin Otte [Mon, 9 Nov 2015 00:44:01 +0000 (01:44 +0100)]
placesview: Don't export API
This is a private object, don't export its symbols.
https://bugzilla.gnome.org/show_bug.cgi?id=756978
Benjamin Otte [Mon, 9 Nov 2015 00:42:41 +0000 (01:42 +0100)]
cssnode: Propagate NTH_LAST_CHILD changes properly
We were just catching the previous sibling before. Now we properly
invalidate all previous siblings (and also all other wiblings, but we
can think about optimizing that later).
Benjamin Otte [Mon, 9 Nov 2015 00:38:39 +0000 (01:38 +0100)]
csstypes: Propagate NTH_CHILD and NTH_LAST_CHILD to siblings
Otherwise, we'd have to mark eveyr child on changes, and it's far easier
to do that once we actually validate.
Benjamin Otte [Mon, 9 Nov 2015 00:29:56 +0000 (01:29 +0100)]
box: Refactor CSS node handling
Only update the node that changed, don't invalidate everything.
Benjamin Otte [Sat, 7 Nov 2015 19:23:44 +0000 (20:23 +0100)]
box: Don't track children visibility
It's not necessary anymore with css nodes.
Benjamin Otte [Sat, 7 Nov 2015 19:13:09 +0000 (20:13 +0100)]
testutils: Add deprecation guards
Matthias Clasen [Mon, 9 Nov 2015 00:19:20 +0000 (19:19 -0500)]
Move gtk_builder_extend_with_template to public header
We export the symbol, so we should not hide it in private
headers.
Matthias Clasen [Sun, 8 Nov 2015 23:40:35 +0000 (18:40 -0500)]
Document gtk_builder_extend_wth_template
Gábor Kelemen [Sun, 8 Nov 2015 22:49:12 +0000 (22:49 +0000)]
Updated Hungarian translation
Balázs Meskó [Sat, 7 Nov 2015 14:43:13 +0000 (14:43 +0000)]
Updated Hungarian translation
Balázs Meskó [Sat, 7 Nov 2015 14:40:53 +0000 (14:40 +0000)]
Updated Hungarian translation
Matthias Clasen [Sat, 7 Nov 2015 05:58:00 +0000 (00:58 -0500)]
Adwaita: Update print dialog styling
Adapt to the changes in the previous commit. With the changes here,
we always render the paper as white, even in the dark theme.
Matthias Clasen [Sat, 7 Nov 2015 05:57:03 +0000 (00:57 -0500)]
print dialog: Use an element name for rendering the paper
Use a transient node with name paper instead of a random
collection of style classes for rendering the papers.
Matthias Clasen [Sat, 7 Nov 2015 05:42:37 +0000 (00:42 -0500)]
Adwaita: Update expander styling
Adapt to the changes in the previous commit.
Matthias Clasen [Sat, 7 Nov 2015 05:40:28 +0000 (00:40 -0500)]
epxander: Port to CSS nodes
Use CSS nodes with name expander and arrow here.
Matthias Clasen [Sat, 7 Nov 2015 04:35:20 +0000 (23:35 -0500)]
scrolledwindow: Document overlay scrolling style classes
Document which style classes are used on scrollbars to
implement overlay scrolling.
Matthias Clasen [Sat, 7 Nov 2015 04:28:22 +0000 (23:28 -0500)]
scrolledwindow: Set positional classes on scrollbars
This might be useful for some themes.
Matthias Clasen [Sat, 7 Nov 2015 03:58:08 +0000 (22:58 -0500)]
scrolled window: Drop unnecessary transient nodes
We already add the .frame style class to the context depending
on the shadow property. No need to save the context and add it
again all the time.
Matthias Clasen [Sat, 7 Nov 2015 03:47:16 +0000 (22:47 -0500)]
window: Don't pass wrong state to context
GtkStyleContext warns nowadays if one queries properties
from a different state. So, don't do that.
Matthias Clasen [Sat, 7 Nov 2015 03:24:20 +0000 (22:24 -0500)]
range: Fixes to the new trough rendering
There was an errant y that caused some troughs to not be drawn.
And also set the state of the fill node.
Matthias Clasen [Sat, 7 Nov 2015 00:38:50 +0000 (19:38 -0500)]
scale: Document the new CSS nodes
Benjamin Otte [Sat, 7 Nov 2015 00:45:35 +0000 (01:45 +0100)]
notebook: Fix copy/paste error
This is from the recent commit
2a1a483edef1c94a795855dec08d91a4421ceb13
Matthias Clasen [Sat, 7 Nov 2015 00:28:56 +0000 (19:28 -0500)]
Adwaita: Update range styling
Adapt to the new CSS nodes for trough rendering. This commit
also brings back visible fill-level rendering for scales, which
was not working for a while. The styling provided for that
(scale trough fill) is just a placeholder to aid in debugging
the implementation.
Matthias Clasen [Sat, 7 Nov 2015 00:25:58 +0000 (19:25 -0500)]
range: Use CSS nodes for all trough rendering
This replaces the somewhat freewheeling use of style classes to
render a part of the trough highlighted and show a fill level.
Matthias Clasen [Fri, 6 Nov 2015 20:20:01 +0000 (15:20 -0500)]
Update mac key theme for css changes
Use the element names for widgets.
Matthias Clasen [Fri, 6 Nov 2015 20:19:36 +0000 (15:19 -0500)]
Update emacs key theme for css changes
Use the element names for widgets.
Benjamin Otte [Fri, 6 Nov 2015 17:57:24 +0000 (18:57 +0100)]
stylecontext: Always warn on style mismatch
For now, always warn when
gtk_style_context_get()/get_padding()/get_margin()/get_border()
get called with the wrong state.
We used to hide this behind an env var because the warnings were
too frequent, but with the recent refactorings, this warning has become
rather important for detecting bugs.
If it's still problematic, we might want to revert this patch before
3.20.
Benjamin Otte [Fri, 6 Nov 2015 17:53:46 +0000 (18:53 +0100)]
range: Use right state when querying margin
Benjamin Otte [Fri, 6 Nov 2015 17:52:13 +0000 (18:52 +0100)]
notebook: Query the right node's padding
Benjamin Otte [Fri, 6 Nov 2015 17:49:26 +0000 (18:49 +0100)]
spinbutton: Use right state when querying padding
Matthias Clasen [Fri, 6 Nov 2015 16:53:42 +0000 (11:53 -0500)]
range: Update trough state
It might make sense for the theme to render an insensitive trough
differently.
Matthias Clasen [Fri, 6 Nov 2015 14:26:25 +0000 (09:26 -0500)]
popover: Don't create transient CSS nodes
There is no need to save the style context here.
Matthias Clasen [Fri, 6 Nov 2015 12:57:03 +0000 (07:57 -0500)]
Cosmetic: Use defines for style classes
Matthias Clasen [Fri, 6 Nov 2015 12:51:15 +0000 (07:51 -0500)]
range: Document fine-tuning style class use
Benjamin Otte [Fri, 6 Nov 2015 15:34:09 +0000 (16:34 +0100)]
acccellabel: Use right state when querying font
This was causing permanent invalidations otherwise because drawing
causes the state of the accel node to change.
Matthias Clasen [Fri, 6 Nov 2015 12:04:14 +0000 (07:04 -0500)]
Adwaita: Update scale styling
Use :first-child/:last-child on the trough for determining
which slider we need.
Matthias Clasen [Fri, 6 Nov 2015 12:01:42 +0000 (07:01 -0500)]
scale: Stop using style classes for marks
We can use :first/last-child for this now.
Matthias Clasen [Fri, 6 Nov 2015 04:42:19 +0000 (23:42 -0500)]
Adwaita: Fix up filechooser styling
Several details of sidebar and places view styling were lost
along the way. Bring back the circular buttons.
Matthias Clasen [Fri, 6 Nov 2015 04:43:32 +0000 (23:43 -0500)]
places view: Remvoe some unused style classes
These style classes were not used in Adwaita, and didn't make
any difference for the appearance.
Matthias Clasen [Fri, 6 Nov 2015 04:41:42 +0000 (23:41 -0500)]
places view: Add an element name
Use placesview as the element name.
Matthias Clasen [Fri, 6 Nov 2015 00:15:43 +0000 (19:15 -0500)]
Adwaita: Redo combo box entry styling
Instead of relying on .linked or + (which doesn't work right in rtl),
use :not(:only-child) to select a button that is not alone inside a
combobox.
Matthias Clasen [Fri, 6 Nov 2015 00:14:38 +0000 (19:14 -0500)]
combobox: Don't add .linked
It interferes with getting the desired styling for combo boxes
with an entry, and is not needed.
Matthias Clasen [Thu, 5 Nov 2015 23:00:51 +0000 (18:00 -0500)]
Fix a typo
Piotr Drąg [Fri, 6 Nov 2015 00:05:00 +0000 (01:05 +0100)]
Updated POTFILES.in
Matthias Clasen [Thu, 5 Nov 2015 21:13:06 +0000 (16:13 -0500)]
window: Add a diagram to the CSS documentation
Matthias Clasen [Thu, 5 Nov 2015 21:07:29 +0000 (16:07 -0500)]
Adwaita: Update window styling
We no longer inherit the style classes on the decoration subnodes,
so we have to adjust some selectors.
Matthias Clasen [Thu, 5 Nov 2015 21:06:49 +0000 (16:06 -0500)]
window: Use permanent CSS nodes
gtk_style_context_save_named() has drawbacks that we want to avoid.
Matthias Clasen [Thu, 5 Nov 2015 20:41:37 +0000 (15:41 -0500)]
tool button: Add element names for tool item subclasses
Add the obvious names to the CSS nodes of GtkRadioToolButton,
GtkToggleToolButton and GtkSeparatorToolItem.
Matthias Clasen [Thu, 5 Nov 2015 20:23:44 +0000 (15:23 -0500)]
flowbox: Add element names
The names used here are flowbox and flowboxchild.
Matthias Clasen [Thu, 5 Nov 2015 18:53:43 +0000 (13:53 -0500)]
Adwaita: Update listbox styling
Adapt to the changes in the previous commit.
Matthias Clasen [Thu, 5 Nov 2015 18:51:58 +0000 (13:51 -0500)]
placessidebar: Use the same element name for rows
Use row as the element name here too.